-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 파운데이션, 컴포넌트, 그래픽 페이지 마크업 #182
base: main
Are you sure you want to change the base?
Conversation
|
Size Change: 0 B Total Size: 680 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- scroll bar 추가 - 사이드바에 border 추가
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨어요! 리뷰 한번만 확인해주세용~
apps/wow-docs/constants/data.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P4;
data
보다는 조금 더 명시적인 파일 이름을 사용하면 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data -> pageData 로 네이밍 바꿔봤습니다!
- 네비게이션 디자인 수정 - 메타데이터 수정 - Sidebar -> Navbar 로 워딩 변경
- data -> pageData 로 파일명 변경
🎉 변경 사항
🚩 관련 이슈
🙏 여기는 꼭 봐주세요!
와우 디자인 시스템
affix 가 붙게끔 생성했습니다.다른 형식이 좋으시면 말씀주세요~